Giters

Manak / npm-programmatic

npm-programmatic is a library that allows you to access npm commands programmatically from javascript

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Unnecessary check for an empty string

chalkpe opened this issue · comments

commented

npm-programmatic/index.js

Lines 72 to 73 in 55ab157

if(stderr == ""){
if (stderr.indexOf("missing")== -1 && stderr.indexOf("required") == -1) {

stderr has been verified to be an empty string already, so why the code checks "missing" or "required" in the empty string again? what is the purpose of it? was it a mistake?