Overriding engagement end date

Question

Overriding engagement end date

jamiesonio opened this issue a year ago · comments

Hi Team,

Thank you for all your work on this tool. I was wondering why the engagement end date for engagements created by the import are defaulted to the year 2999, I am new to DefectDojo and was wondering if this was a best practice or intended workflow for CI/CD engagements. I see the code here is where these values are being defined https://github.com/MaibornWolff/dd-import/blob/main/dd_import/dd_api.py#L103-L104, happy to put in a PR to make these environment variables as it serves my use case but was looking for more insight into why this was setup this way.

Best,
J

jamiesonio · Answer 1 · Tue Jan 24 2023 02:33:15 GMT+0800 (China Standard Time)

I added a PR here for this functionality, please decline if its not desired
#73

Stefan Fleckenstein · Answer 2 · Tue Jan 24 2023 20:01:32 GMT+0800 (China Standard Time)

Hi @jamiesonio, thank you for your PR. I will have a look at it as soon as possible.

Stefan Fleckenstein · Answer 3 · Thu Feb 02 2023 19:40:22 GMT+0800 (China Standard Time)

Hi @jamiesonio, I have changed the second environment variable to DD_ENGAGEMENT_TARGET_END so that it matches the parameter of DefectDojo.

Your change has been released today with release 1.0.9.