MahmoudMabrok / QuranyApp

Open Source HolyQuran app that provide Read, Listen, Tafseer, Test all of them and app is very small size.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

(BUG) (QuranyApp version 1.9.0 ) Download Audio option not working properly

saraji-ali opened this issue · comments

Project Information

Expected behavior

When I click on the option of downloaded audio, all the audio files should be downloaded

Actual behavior

When I click the Download Audio option audio does not download

How to reproduce

1-Download the app and open it
2- At the top right click three vertical dots
3- Click Download Zone
4- click on Download Audio option
5- see bug

  • Browser/App version: version 1.9.0
  • Operating system: 6.0.1
  • Smartphone: Galaxy j7

Recording Of The Bug

20190520_015930

My Github Account

https://github.com/facebook-786

I am sorry I am doing exams so I couldn't check and reply for contributors.

ok sir no problem

@MahmoudMabrok is this issue fixed? or should I take care of it?

@MahmoudMabrok I can see there is a lot of code refactoring that needs to be done, should I do this?

I DID some refactoring to kotlin and still need more.
but as there is no UNit tests to check if code is has no effect side and do same behaviour we can delay refactor to another span of time .
@abduldblogger

@abduldblogger it did not solve yet. U can work on it

i think it needs good design of code and handle many cases.
I remeber i did same task before.
i will share my thoughts with you in next free time ISA

@MahmoudMabrok also I am unable to find such an option as mentioned in this issue on master branch

@abduldblogger it should exist, but may with a running app i hide ut.

@abduldblogger would you like to work on this?

@MahmoudMabrok I wanted to work on it, but unfortunately I am very busy these days

@abduldblogger no problem brother. Allah wiht you.

the issue was some files are corrupted so the download process is aborted.