Giters

Magenerds / PageDesigner

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Plus icon false trigger

gewaechshaus opened this issue · comments

commented

Hey there,

with enabled JS minification, (bundling) and merging the module doesn't work as excepted (in production mode).

I only did a few tests:

  • Compared my system to the demo (https://demo-pagedesigner.magenerds.com/admin/cms/page/). It seems like the demo is running in developer mode as by configuration JS minification and merging are enabled
  • Switched to developer mode, everything is working like in the dev
  • No significant errors on the console, will have a look at the logs now

Biggest issue: can't add a new block by clicking the + icon... It looks like this line is always getting triggered
https://github.com/Magenerds/PageDesigner/blob/master/view/adminhtml/web/js/page_designer.js#L182

Issue

  • The editor will never
    So maybe someone can verify this before we dig deeper into the code.

Regards
Jan

commented

Hi Jan,
thanks for reporting! We just comitted a fix for the editor. Does it help?
Are there more issues? You wrote that you can't add blocks via the + icon. Maybe you can separate the problems in separate issues? :-)

commented

Hey @sydekumf, please create a release for it :)

commented

@JSchlarb @sydekumf - THX a lot, I will test your fix in the next minutes...

commented

@JSchlarb @sydekumf - That doesn't seem to do the trick, same result as before :(

Triggered:
https://github.com/Magenerds/PageDesigner/blob/master/view/adminhtml/web/js/page_designer.js#L182

Image

Maybe we should test some logic so sort the requests.

commented

Got it :D. The controls are overlapping.

commented

Lol, to be honest, I didn't thought that simple :) (as always ;)) Screenshots speaks more than words in our world :)

commented

Maybe you can confirm it by executing this jQuery('.pd-col-content-controls').css('display', 'none');. Of course this will cause other problems but it will show that I'm on the right way :)

commented

Looks good... Seems to overlap, could trigger the plus icon like it should this way.

Another way to verify: If you put in a new row and resize the default element to the smallest possible size, the plus icon does get triggered.

commented

In general I also noticed a visual difference related to the box sizes in our case. They don't stretch to fullsize like in the demo and are kind of unresponsive and limited in sizing. I can put this in another issue to keep things clean.

#4

commented

Hi Jan,
This one is also related to this expect the min with. PR #5 should fix the issue with overlapping controls.