MadFishTheOne / madfish-webtoolkit

Automatically exported from code.google.com/p/madfish-webtoolkit

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Very inefficient counter increment.

GoogleCodeExporter opened this issue · comments

Code in Server.cpp:
        clientsMutex.Lock();
        clientsCount++;
        clientsMutex.Unlock();

Why don't use an atomic operations? Such as InterlockedIncrement on win32

Original issue reported on code.google.com by gandjus...@gmail.com on 8 Jun 2009 at 5:36

There is no InterlockedIncrement in *nixes.

Original comment by madfisht...@gmail.com on 13 Jun 2009 at 12:07

Thread pool is now implemented, so these functions will be called rarely, so 
this is
not important. No need for introducing win32-specific locking.

Original comment by madfisht...@gmail.com on 15 Jun 2009 at 6:47

  • Changed state: WontFix