Giters

MSUTeam / MSU

Modding Standards and Utilities for Battle Brothers

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[BUG] `onOtherActorDeath` should be hookLeaves

LordMidas opened this issue · comments

commented

Versions

  • Game: [e.g. 1.5.0.13]
  • MSU: [e.g. 1.2.2]

Describe the bug
onOtherActorDeath event is currently called via a hook on actor.nut. This leads to issues where when a goblin_wolfrider dies and spawns a wolf corpse, it doesn't call the base onDeath function and therefore the event doesn't run.

This event should be called via a hookLeaves type hook.

commented

I wonder if this is causing bugs for me. I.e. a goblin or wolf not inheriting a quirk after unmounting in Standout Enemies.

commented

We can do this in a 1.3.X release so not a priority right now but yes something it'd be good to get to.

commented

We can do this in a 1.3.X release so not a priority right now but yes something it'd be good to get to.

It's already done in the port to modern hooks #316