MSRevive / MasterSwordRebirth

Continuation of Master Sword Classic/Continued.

Home Page:https://msrebirth.net/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

The spawn no-collusion system doesn't activate some triggers.

SaintWish opened this issue · comments

The no-collusion system prevents some triggers from activating on player touch until the player is turned solid again. An example of a trigger broke by this is CAreaMusic. Also when players are non-solid they're unable to targeted with spells, like ice shield.

commented

As mentioned in the PR:

Triggers now work properly and the system has been made much more aggressive in removing nocollide to make it easier to get collisions back.

The whole Music thing is completely broken, no music ever plays despite the point and the area triggers firing the script event and the scripts firing the associated function internally. Unfortunately I can't get symbols for the Soundengine to debug it's incoming commands, so I have no idea where the failure is.

commented

Screenshot 2023-02-12 170325

Bisecting to this commit. Likely a function called outside of our code being hijacked for the music, any commit before this has working sound as tested on this map:
musictest.zip

Added back the removed hud music code, music works fine now, the music usermessage is handled there (recv)