Giters

MMGGYY66 / my-portfolio-website

Practising building a portfolio website. It is an HTML & CSS project that just displays a toolbar and a headline section but has many configurations that keep the code structure clean.

Home Page:https://mmggyy66.github.io/my-portfolio-website/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Issues in the last two commits

SFarida opened this issue · comments

commented

Hello, while your code looks great and is working as expected please kindly checkout these comments on your last two commits (1, 2)

Highlights

@SFarida

  • Kindly check that there is no space in your class names attributes for best practice on line 32 and 34.
    @kensteph
  • I examined your code. You did a great work! Please kindly consider refactoring your code in the index.js file 1- Line 37,43 : I think it would be better if you do it like you did for line 41. By doing this you will Don't Repeat Yourself.
    @edahigure
  • The code is working well. Maybe just to find out why the events only work with arrow functions.
commented

Thank you. I fixed the issues.