MISS3D / s2p

This repository is not maintained, please use https://github.com/centreborelli/s2p instead.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

incorrect disparity range manipulation

gfacciol opened this issue · comments

This line (and surrounding code) is in charge of extending the disparity range for the stereo matching:

disp_min *= (1 - np.sign(disp_min) * cfg['disp_range_extra_margin'])

But these manipulations are incorrect. If disp_min=0 to begin with, then no multiplication will ever increase the disparity range. The correct way to increase the disparity range is with:

dmin-= (dmax-dmin)* cfg['disp_range_extra_margin'])
dmax+= (dmax-dmin)* cfg['disp_range_extra_margin'])