Real-time simulation performance monitoring needs improvement

[Spencer Bryngelson]

Real-time simulation performance monitoring needs improvement

• This code:

  MFC/src/simulation/m_time_steppers.fpp

  Lines 310 to 314 in 4833971

   if (t_step >= 4) then 
       time_avg = (abs(finish - start) + (t_step - 4)*time_avg)/(t_step - 3) 
   else 
       time_avg = 0d0 
   end if 

  
  is repeated for each time stepper verbatim. Needs DRY principle.

• The metric of seconds is not particularly helpful and confusing to compute. The metric should be grid point per second per RHS evaluation.

  • This should show up as a replacement for "Final time" here as well:

    MFC/src/simulation/m_start_up.fpp

    Line 946 in 4833971

     print *, "Final Time", time_final 

    (and likely elsewhere).

• The metrics shown in the docs here https://github.com/MFlowCode/MFC/blob/master/docs/documentation/expectedPerformance.md should be updated accordingly.