Fix compatibility with ESPHome 2022.5.0

Question

Fix compatibility with ESPHome 2022.5.0

gorbunovav opened this issue 2 years ago · comments

Describe the bug
With the ESPHome 2022.5.0 release the set method of the Number component was removed.

The proper way to set the value is to use the make_call method:
https://esphome.io/components/number/index.html?highlight=make_call

To Reproduce
Update to ESPHome 2022.5.0 and try to compile the firmware.

Expected behavior
Compilation completes succesfully.

Kai Bepperling · Answer 1 · Sun May 29 2022 15:12:25 GMT+0800 (China Standard Time)

Thanks. Yes unfortunately they removed that function. I saw that you are working on a PR? Happy to merge if you are ready. The PR needs to be merged to upstream master. If the GitHub app is not lying you opened a PR to your fork branch

Andrey Gorbunov · Answer 2 · Sun May 29 2022 15:14:17 GMT+0800 (China Standard Time)

@Lyr3x Hi! Yes, the PR is ready to be merged.

Kai Bepperling · Answer 3 · Sun May 29 2022 15:15:24 GMT+0800 (China Standard Time)

Thank you very much for the contribution

Kai Bepperling · Answer 4 · Wed Jun 01 2022 18:29:27 GMT+0800 (China Standard Time)

Can you open the PR to upstream please? 🙏

Andrey Gorbunov · Answer 5 · Wed Jun 01 2022 18:34:37 GMT+0800 (China Standard Time)

@Lyr3x oh, sorry - I've specified the wrong target in my PR. Fixed