Moving client/angularjs to leverage ZURB not TWITTER

Question

Moving client/angularjs to leverage ZURB not TWITTER

webthingee opened this issue 11 years ago · comments

It's so much better... any objections to making this change?

I plan to use a slightly different directory structure, but the info http://pburke.de/yeoman-foundation-sass-luv/ is very valid.

Jerad Bitner · Answer 1 · Tue Apr 23 2013 21:59:12 GMT+0800 (China Standard Time)

No objections.

Micah Godbolt · Answer 2 · Tue Apr 23 2013 22:04:32 GMT+0800 (China Standard Time)

Plus Plus ++ all the things!

Sean Lange · Answer 3 · Wed Apr 24 2013 05:48:06 GMT+0800 (China Standard Time)

Sean Lange commented 11 years ago

Jerad Bitner · Answer 4 · Wed Apr 24 2013 06:34:36 GMT+0800 (China Standard Time)

Thanks, but ... now my shit's all broken.

Jerad Bitner · Answer 5 · Wed Apr 24 2013 07:21:25 GMT+0800 (China Standard Time)

Had to do a gem install zurb-foundation. someone neglected to mention that. updated the readme.

Sean Lange · Answer 6 · Wed Apr 24 2013 08:00:54 GMT+0800 (China Standard Time)

Argh, for some reason I was thinking that it would get it because it was in the require in the Gruntfile.js.
Sry Team :(

Sean Lange · Answer 7 · Wed Apr 24 2013 08:37:22 GMT+0800 (China Standard Time)

Zurb needs jquery to work properly (the script functions at least)
<script src="http://code.jquery.com/jquery-1.9.1.min.js"></script>

that is only IF we want to use any of the scripts..

Jerad Bitner · Answer 8 · Wed Apr 24 2013 08:51:13 GMT+0800 (China Standard Time)

Yeah I was a little shocked at the amount of scripts you added with zurb, especially when they all err out. Let's remove those until/if we actually need them.

Micah Godbolt · Answer 9 · Wed Apr 24 2013 12:18:22 GMT+0800 (China Standard Time)

as we are moving the prototyping into the angular folder we won't be needing to use zurb (we're building up the framework as we go). So i've removed the files and requirements.

Sean Lange · Answer 10 · Wed Apr 24 2013 21:15:26 GMT+0800 (China Standard Time)

bummer, would have been nice to leave it in there as it provided some extra stuff to work with as we learn angular, seems silly to create an extra branch just to have zurb available. Also would provide as a good guide for things we would want to implement into the wireframing.

Sean Lange · Answer 11 · Wed Apr 24 2013 21:23:20 GMT+0800 (China Standard Time)

there appears to be some issues...

Sean Lange · Answer 12 · Wed Apr 24 2013 21:33:25 GMT+0800 (China Standard Time)

Updated readme.
Someone should do a fresh install, on a machine without gems to see if we are all clear.

Sean Lange · Answer 13 · Wed Apr 24 2013 21:36:32 GMT+0800 (China Standard Time)

@micahgodbolt Gruntfile.js, linking to config.rb... love it!!

Sean Lange · Answer 14 · Wed Apr 24 2013 21:42:16 GMT+0800 (China Standard Time)

Grunt provides testing... is there a way to write a test for checking this??? hmmm..... I have never worked with tests, would be a fun hangout problem to solve... @sirkitree ??

Jerad Bitner · Answer 15 · Wed Apr 24 2013 21:50:19 GMT+0800 (China Standard Time)

The testing (afaik) is limited to what is in the code base. Seeing as gems are a component that is installed on a particular system, I don't know if we can really 'test' for them. I think we just need to modify our install instructions to include whatever gems we're using and keep it up to date.