LubosD / twinkle

Qt 5 port of Twinkle

Home Page:http://twinkle.dolezel.info

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Prefill authentication form popup with current username/password values

fbriere opened this issue · comments

When authentication fails, the authentication form that pops up currently has blank username/password fields. Usually, these would be prefilled with either values copied from the profile (for the first attempt), or what was typed in the form during the previous attempt.

@DennisD2 has submitted #237 which performs the first half by retrieving the profile values from within the form. While digging around during my review, I discovered that Twinkle is already set up to prefill the form; it's simply not doing it correctly. I'll submit a PR shortly to fix this bug.

(I'm opening this issue merely to serve as a record for why we have two PRs that basically solve the same problem.)