Coding conventions (SwiftLint)

Question

Coding conventions (SwiftLint)

huyphams opened this issue 6 years ago · comments

Suggesting a New Feature

Hi folks, I just came here and I see something. Lona is in the first stage of development and still missing coding conventions. There are also have some invalid configs. It would be great if we have rules for coding. It makes Lona code readable and clean.

Proposed Implementation

What do you guys think about to add SwiftLint to Lona?
Remove invalid configs (invalid target) and update .gitignore.
After adding SwiftLint, we will have a lot of convention warnings => refactor it.

Submitting a Bug Report

If you guys interesting in my suggestion, I can give a PR 😄

Noah Tran · Answer 1 · Thu Jan 18 2018 16:19:32 GMT+0800 (China Standard Time)

It's cool @huyphams.
Regrading to SwiftLint - I honestly love it.

I intend to integrate TravisCI as long as the bot from Danger System in next PR. The conjunction of them are so perfectly for an OSS. It strictly keeps our style convention and contributors on right track 👍

Devin Abbott · Answer 2 · Fri Jan 19 2018 03:40:06 GMT+0800 (China Standard Time)

@huyphams Sounds fantastic! This will be really helpful for new folks looking to contribute.

👍 👍 👍

Henry Pham · Answer 3 · Fri Jan 19 2018 12:28:13 GMT+0800 (China Standard Time)

Hey thanks, I'm working on it. I will create a PR on Sunday 😄

Devin Abbott · Answer 4 · Wed Jan 24 2018 02:32:44 GMT+0800 (China Standard Time)

Merged! I guess next step is to fix all the warnings? 😭

Henry Pham · Answer 5 · Wed Jan 24 2018 02:34:59 GMT+0800 (China Standard Time)

Thanks!!!
Merged! I guess next step is to fix all the warnings? 😭 => yeah, but don't worry. I'm here 😄

Devin Abbott · Answer 6 · Tue May 08 2018 01:28:56 GMT+0800 (China Standard Time)

SwiftLint is 💯 . Thanks for adding it!