Fix that array size passing is too eager with assignments (HAST-321)

[Zoltán Lehóczky]

Here:

Hastlayer-SDK/src/Hastlayer/Hast.Transformer/Services/ConstantValuesSubstitution/ConstantValuesMarkingVisitor.cs

Lines 216 to 226 in aed9b6f

                 AssignmentHandler = assignmentExpression => 
                 { 
                     if (assignmentExpression.Left is MemberReferenceExpression memberReferenceExpression) 
                     { 
                         _arraySizeHolder.SetSize( 
                             memberReferenceExpression.FindMemberDeclaration(_typeDeclarationLookupTable), 
                             arrayLength); 
                     } 
  
                     _arraySizeHolder.SetSize(assignmentExpression.Left, arrayLength); 
                 }, 

The array size from the right will be passed to the left in any case, even if on the right the array is e.g. an argument to a method call.

Let's fix this so it only passes the size if the assignment is actually an array assignment.

Jira issue