Giters

Loki-Astari / ThorsSerializer

C++ Serialization library for JSON

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Invalid enum values causes undefined behavior

DonDoff opened this issue · comments

commented

When an invalid enum class value is serialized, it doesn't throw an exception, instead undefined behavior occurs.

Code:

#include <iostream>

#include "ThorSerialize/JsonThor.h"
#include "ThorSerialize/Traits.h"

enum class ENUM : uint8_t { AAAAA, BBBBB, CCCCC };
struct CLASS {
  ENUM val = ENUM::AAAAA;
  int y = 5;
};

ThorsAnvil_MakeEnum(ENUM, AAAAA, BBBBB, CCCCC);
ThorsAnvil_MakeTrait(CLASS, val, y);

int main(int /*argc*/, char* argv[]) {
  using ThorsAnvil::Serialize::jsonExporter;
  CLASS a;
  a.val = static_cast<ENUM>(5);

  ThorsAnvil::Serialize::PrinterInterface::PrinterConfig config;
  config.catchExceptions = false;

  std::cout << jsonExporter(a, config) << std::endl;
  return 0;
}

Run with:

g++ -std=c++17 -Ibuild/include -Lbuild/lib doc/example_issue.cpp -lThorSerialize17 -lThorsLogging17 -lThorsStorage17 -ldl -o example_issue
sudo ldconfig /home/adoff/Documents/git/ThorsSerializer/build/lib
./example_issue

Output:

	{ 
		"val": "", 
		"y": 5
	}

This output was on my machine, but on an ARM platform this actually crashed the application.
I would expect an exception to be thrown.

Environment:

16:42 $ uname -a
Linux adoff-ThinkPad-T590 5.4.0-125-generic #141-Ubuntu SMP Wed Aug 10 13:42:03 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Compiler:

16:42 $ g++ -v
Using built-in specs.
COLLECT_GCC=g++
COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-linux-gnu/9/lto-wrapper
OFFLOAD_TARGET_NAMES=nvptx-none:hsa
OFFLOAD_TARGET_DEFAULT=1
Target: x86_64-linux-gnu
Configured with: ../src/configure -v --with-pkgversion='Ubuntu 9.4.0-1ubuntu1~20.04.1' --with-bugurl=file:///usr/share/doc/gcc-9/README.Bugs --enable-languages=c,ada,c++,go,brig,d,fortran,objc,obj-c++,gm2 --prefix=/usr --with-gcc-major-version-only --program-suffix=-9 --program-prefix=x86_64-linux-gnu- --enable-shared --enable-linker-build-id --libexecdir=/usr/lib --without-included-gettext --enable-threads=posix --libdir=/usr/lib --enable-nls --enable-clocale=gnu --enable-libstdcxx-debug --enable-libstdcxx-time=yes --with-default-libstdcxx-abi=new --enable-gnu-unique-object --disable-vtable-verify --enable-plugin --enable-default-pie --with-system-zlib --with-target-system-zlib=auto --enable-objc-gc=auto --enable-multiarch --disable-werror --with-arch-32=i686 --with-abi=m64 --with-multilib-list=m32,m64,mx32 --enable-multilib --with-tune=generic --enable-offload-targets=nvptx-none=/build/gcc-9-Av3uEd/gcc-9-9.4.0/debian/tmp-nvptx/usr,hsa --without-cuda-driver --enable-checking=release --build=x86_64-linux-gnu --host=x86_64-linux-gnu --target=x86_64-linux-gnu
Thread model: posix
gcc version 9.4.0 (Ubuntu 9.4.0-1ubuntu1~20.04.1)