Loki-Astari / ThorsSerializer

C++ Serialization library for JSON

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Derived class without new members

opened this issue · comments

I implement the webservice for a given API and I am forced to have a derived class with no new members in it (the external API wants that). But ThorsAnvil_ExpandTrait expects to give a list of members.

So this code

struct Derived : public Base {
    ~Derived() override = default;
    ThorsAnvil_PolyMorphicSerializer(Derived);
};

ThorsAnvil_ExpandTrait(Base, Derived);

does not compile:

error: expected unqualified-id
ThorsAnvil_ExpandTrait(Base, Derived);
^
/usr/local/include/ThorSerialize/Traits.h:277:5: note: expanded from macro 'ThorsAnvil_ExpandTrait'
    ThorsAnvil_MakeTrait_Base(ThorsAnvil_Parent(0, ParentType, DataType, __VA_ARGS__, 1), Parent, 0, DataType, __VA_ARGS__, 1); \

Thanks for the error report.
I'll have a look on Sun 2019/Feb/17

OK I have a fix.
It is tested by the new unit test: DerivedTypeNoNewMembers

Updates have been pushed to git.
I am submitting a request to brew to update ThorsSerializer. This can take a day. When done I will update and close this error report.

brew pull request started
Homebrew/homebrew-core#37024

New version now installable with homebrew.

Noticed another issue.

OK I have a fix.
It is tested by the new unit test: DerivedTypeNoNewMembersPolyMorphic

Updates have been pushed to git.
I am submitting a request to brew to update ThorsSerializer. This can take a day. When done I will

New version now installable with homebrew.
Homebrew/homebrew-core#37040