Tokens in inline IL signatures not mapped to new assembly
toptensoftware opened this issue · comments
Inline signatures might contain tokens that need to be converted to tokens for the new assembly's metadata.
ILPack/src/IL/MethodBodyWriter.cs
Line 87 in 610c6ac
btw: I wouldn't stress too much about this. The only instruction that uses this is calli and trying to find examples of it in netcore is really difficult. I just did a ildasm/grep across the entire netcore system dlls directory and couldn't find a single example. Windows .NET framework on the other hand has many instances of it.
Also, Roslyn doesn't appear to use Calli at all:
Compared to Call which it does:
@vermorel Can we postpone this issue for now? The calli OpCode is used now by Roslyn mostly for the native interop and we have to proceed with this case correctly (with rewriting the signature using proper arguments' types tokens) but it's not as easy as I've thought before.
@OlegRa No problem to postpone.