LiveTL / LiveTL

Get live translations for YouTube streams, crowdsourced from multilingual viewers!

Home Page:https://livetl.app/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[Bug]: Cannot use BetterTTV when HyperChat disabled

r2dev2 opened this issue · comments

Checklist

  • This is an issue for LiveTL, not Hyperchat. I will go to the Hyperchat repo to report an issue with Hyperchat.
  • This is an issue for the LiveTL web extension, not LiveTL iOS or LiveTL Android. I will go to the iOS or Android repo to report issues for those platforms.
  • This issue is not a matter of opinion. If it is, I will use the feature suggestion issue template.
  • I have checked for a duplicate or similar issue. I made sure to check closed issues as well.
  • I am still able to reproduce the issue after I reinstall the extension.
  • I have clear instructions to reproduce the bug, even on another machine.
  • I am not suggesting a feature. If I am, I will use the feature suggestion issue template.
  • By submitting this issue, you agree to follow our Code of Conduct

Describe the bug

When LiveTL is installed, users are unable to launch BetterTTV settings when HyperChat is disabled.

image

Steps To Reproduce

  1. install livetl and betterttv
  2. go to https://www.youtube.com/watch?v=jfKfPfyJRdk
  3. disable hyperchat
  4. click on triple dot next to hc button
  5. click on launch betterttv settings

Expected behavior

settings should launch

What browsers are you seeing the problem on?

Firefox

Anything else?

This may be an issue with HyperChat, not LiveTL, will analyze further.

Reported by tunnelsnakes in ltlcord

Ok so I can confirm this issue with the deployed LiveTL but the issue is not present when I build locally????????

Never mind, I can reproduce by checking out v8.3.12.

It seems however that #450 has somehow also fixed this issue?????

@KentoNishi can you release new version

will do 2nite prolly