LiveTL / LiveTL

Get live translations for YouTube streams, crowdsourced from multilingual viewers!

Home Page:https://livetl.app/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[Bug]: Parent page scrolls to filtered message on Firefox

ChrRubin opened this issue · comments

Checklist

  • This is an issue for LiveTL, not Hyperchat. I will go to the Hyperchat repo to report an issue with Hyperchat.
  • This is an issue for the LiveTL web extension, not LiveTL iOS or LiveTL Android. I will go to the iOS or Android repo to report issues for those platforms.
  • This issue is not a matter of opinion. If it is, I will use the feature suggestion issue template.
  • I have checked for a duplicate or similar issue. I made sure to check closed issues as well.
  • I am still able to reproduce the issue after I reinstall the extension.
  • I have clear instructions to reproduce the bug, even on another machine.
  • I am not suggesting a feature. If I am, I will use the feature suggestion issue template.
  • By submitting this issue, you agree to follow our Code of Conduct

Describe the bug

When using Embed Mode on Firefox, scrollIntoView will also scroll the entire parent page to the specified element. This is especially apparent when using YouTube's theater mode, where the chat and LiveTL are off-screen.

This might be a problem with Firefox's implementation of scrollIntoView, based on this currently unanswered SO post.

Steps To Reproduce

  1. Open a stream/VOD with YT theater mode.
  2. Launch LiveTL in embed mode.
  3. Wait for a filtered message.

Expected behavior

The parent page doesn't scroll to the filtered message.

What browsers are you seeing the problem on?

Firefox

Anything else?

https://gfycat.com/ko/boldunsightlyherald

good ol firefox