LiveSplit / livesplit-core

livesplit-core is a library that provides a lot of functionality for creating a speedrun timer.

Home Page:https://livesplit.org/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Hotkeys do not work when num lock is active

tp971 opened this issue · comments

On my system, hotkeys do not work at all when num lock is active. I used the desktop prototype (https://github.com/LiveSplit/livesplit-core). Here is some maybe relevant information:

OS: Debian 12.1 "Bookworm"
DE: Xfce 4.18
rustc: 1.71.1

Alright, with @Pheenoh helping me debug this issue we figured out that the way we register the modifiers (and honestly the only way X11 seems to directly support this) means that no other modifier combination is valid for the hotkey. And unfortunately having the numlock on counts as a modifier. I'll look into ways to fix this.

You could have an option to always register two hotkeys—one with and without numlock—and then just coalesce them.

Yeah the solution is probably to register every combination that we are not interested in. It just combinatoricly "explodes" because of num lock, scroll lock, caps lock and co.