Giters

LiveSplit / livesplit-core

livesplit-core is a library that provides a lot of functionality for creating a speedrun timer.

Home Page:https://livesplit.org/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[ASR] Allow changing settings at runtime

apple1417 opened this issue · comments

commented

Currently, if you change any settings the autosplitter is completely reloaded. This is a regression compared to ASLs, which can handle settings changes completely fine (if they're written correctly). You cannot rely on users not changing settings mid run - a common scenario is something like "I made new splits" -> "why didn't it split" -> "oh I forgot to turn on the option" -> "let's change it now". Since reloading the autosplitter loses all internal state, doing this could completely mess up a run.

Proposal: just don't reset the script, and make calling user_settings_add_bool return the current value if a setting already exists. You can hide calling it whenever you want to access settings behind some wrapper in user space.