Current version does not install

Question

Current version does not install

LaurensRietveld opened this issue 7 years ago · comments

There is a problem with the current version: the deps/libcds/includes directory is not part of the published npm package.
This omission is caused by this .gitignore file: https://github.com/rdfhdt/hdt-cpp/blob/develop/libcds/include/.gitignore

We'll submit a PR to hdt-cpp removing the gitignore and release a patch version. I'll leave it up to you to release the HDT-node patch version.

Reason we missed this issue is that we were testing against the HDT-Node git repo, that doesnt exclude files that npm publish would exclude. We could consider adding npm pack to the travis build, and trying the install the output of that command, but not sure whether that's worth the effort

Ruben Verborgh · Answer 1 · Thu Jan 18 2018 17:17:37 GMT+0800 (China Standard Time)

Good catch. Let's indeed also do npm pack on Travis.

Laurens Rietveld · Answer 2 · Thu Jan 18 2018 17:56:45 GMT+0800 (China Standard Time)

Hdt-cpp has a patch release (1.3.1) with the included fix

Ruben Verborgh · Answer 3 · Thu Jan 18 2018 17:58:05 GMT+0800 (China Standard Time)

Thanks, will follow up and release a patch here as well.

Laurens Rietveld · Answer 4 · Thu Jan 18 2018 23:51:55 GMT+0800 (China Standard Time)

Ah, a note about the release: the .gitmodule file is still pointing to the hdt-node branch on hdt-cpp. There's no need for that anymore, so we can simply use the master branch

Ruben Verborgh · Answer 5 · Fri Jan 19 2018 04:15:03 GMT+0800 (China Standard Time)

Deprecated v2.0.1.

Ruben Verborgh · Answer 6 · Sun Jan 21 2018 05:55:57 GMT+0800 (China Standard Time)

Resolved by 33a8b7d.