Config option to select min time or vote skip
hamishfagg opened this issue · comments
I think some users will probably prefer the old skipping, where anyone can skip after a certain amount of time. It shouldn't be too much work to make this configurable to select between the two.
Good idea! But another idea would be too always keep the two options, with something like this:
- One option to define minimum number of votes (defaults to 3 for example)
- One option to define amount of play time needed to bypass the vote (defaults to 5 minutes for example)
Yeah that's a better idea. So number of votes to skip could be set to 1 to disable it, and min play time could be set to 0 to disable it. Otherwise you could have a combination of both =)
EDIT: What would be the preferred behaviour if (in your example) 3 votes had been reached before 5mins had played?
I would say that the first encountered skip condition win.
In that case, we ignore the minimum time and consider that the music should be skipped because we have enough votes.
How is this going? I would love to disable the vote-skip system, the skip-after-set-time would be perfect for my use.