wget returning 404 on valid requests in python3

Question

wget returning 404 on valid requests in python3

murt opened this issue 2 years ago · comments

For whatever reason the much more common "wget" module for python is returning 404s when attempting to download the cef binaries even though the URLs are definitely correct.

It may be worth noting in the README, as per this Stack Overflow Question, using "python3-wget" resolves the issue without having to change anything in the build.py

Raphipod commented 2 years ago

Sure!

Quentin Quadrat · Answer 1 · Thu Jul 14 2022 15:57:43 GMT+0800 (China Standard Time)

@murt Thank to you I just realized that I forgot to copy prerequisite section from the original project:
https://github.com/stigmee/install#step-2-install-python3-packages

Quentin Quadrat · Answer 2 · Thu Jul 14 2022 16:11:22 GMT+0800 (China Standard Time)

@murt Ok I fixed the doc. Please re-open the ticket if this documentation is still unclear.

Raphipod · Answer 3 · Fri Jul 15 2022 01:13:49 GMT+0800 (China Standard Time)

Installed the recommended package "wget" instead of "python3-wget" as stated in the README, but I'm still getting this error while running build.py:

urllib.error.HTTPError: HTTP Error 404: Not Found

File link downloads fine through the webbrowser.

I'm going to look at the version number parser in build.py because it's quite sophisticated for downloading a single file.

Raphipod · Answer 4 · Fri Jul 15 2022 01:23:18 GMT+0800 (China Standard Time)

Turns out that URL percent encoding is causing the issue. I'm going to open a PR with the fix, and while I am at it, I'll update the CEF version, too.

Quentin Quadrat · Answer 5 · Fri Jul 15 2022 01:43:53 GMT+0800 (China Standard Time)

Installed the recommended package "wget" instead of "python3-wget" as stated in the README, but I'm still getting this error while running build.py:

Hi @raphipod install python3-wget ! Do not install wget :) I'm a Python noob: is wget more official than python3-wget ? Except you and @murt people on my team did not get issues with URL encoding with python3-wget

Raphipod · Answer 6 · Fri Jul 15 2022 01:52:45 GMT+0800 (China Standard Time)

No worries. It seems that python3-wget is "just" a rewrite for Python 3.
Concerning the URL encoding issues, I really don't know why it fails at my end

Quentin Quadrat · Answer 7 · Fri Jul 15 2022 02:10:04 GMT+0800 (China Standard Time)

@raphipod I tried quickly: I uninstalled python3-wget and installed back wget and the + seems working but not the %2B (by the way, when you copy the URL from your browser you have %2B). At the opposite, from my memory, python3-wget does not like + but prefer %2B, and both uses import wget and requirements.txt generates wget for python3-wget :( :(

Quentin Quadrat · Answer 8 · Fri Jul 15 2022 02:19:05 GMT+0800 (China Standard Time)

Concerning the URL encoding issues, I really don't know why it fails at my end

I think this is a mix up between python3_wget and wget while using import wget

Raphipod · Answer 9 · Fri Jul 15 2022 02:24:12 GMT+0800 (China Standard Time)

Yeah, we should use python3-wget, already corrected that in #2

Quentin Quadrat · Answer 10 · Fri Jul 15 2022 03:06:32 GMT+0800 (China Standard Time)

@raphipod @murt I have radically changed of python package for downloading :) no more wget ! I added the requirement file and updated README. I also updated CEF version. I hardly checked. Tell me if this is ok for you. If ok @raphipod you can cancel your PR

Raphipod · Answer 11 · Fri Jul 15 2022 03:40:30 GMT+0800 (China Standard Time)

I just noticed that you've commented out the colon in line 346, it exits.

Quentin Quadrat · Answer 12 · Fri Jul 15 2022 03:45:36 GMT+0800 (China Standard Time)

I just noticed that you've commented out the colon in line 346, it exits.

:( I've git push force. You can do git pull --rebase origin master

Raphipod · Answer 13 · Fri Jul 15 2022 04:02:58 GMT+0800 (China Standard Time)

All right, it downloads now without errors! If @murt can confirm that too, that would be great.