Leathong / openscad-support-vscode

OpenSCAD language support for VSCode

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Fix syntax errors thrown with trailing comma in arg list

DeflateAwning opened this issue · comments

The following is valid OpenSCAD, at least in the current preview builds:

include <BOSL2/std.scad>

zcyl(
	d=screw_d,
	h=100,
);

Note the comma after h=100.

Currently, this plugin highlights an error on that symbol ("missing identifier"). It should not report an error.

The latest version of tree-sitter-openscad seems to have solved this problem, I will upgrade.

This issue appears to still be present. Is there anything more that can be done about it?

This issue appears to still be present. Is there anything more that can be done about it?

Present in the released version or the unreleased version? Considering latest release was 2023-05-24 but there has been commits here since that time

Can you do a release then?

Can you do a release then?

I'm not the maintainer, just trying to figure out if it's just a release that's needed or more

Doesn't look like the version number on the dependency has been bumped yet. Likely need that, and then a release too

The PR of tree-sitter-openscad is not merged yet.

This PR is finally merged to the tree-sitter-openscad library! This project can finally be updated.

@DeflateAwning I tried the last version 0.5.0 of tree-sitter-openscad this issue still exist.