LeastAuthority / python-challenge-bypass-ristretto

Python bindings for Brave's challenge-bypass-ristretto library

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

RandomToken is misleadingly named

exarkun opened this issue · comments

We have a naming scheme for the Python types. It has such names as "SignedToken", "BlindedToken", "UnblindedToken", and ... "RandomToken". The naming convention implies that these are all tokens of different sorts.

However, "RandomToken" does not actually follow the pattern. In the parlance of the challenge-bypass-ristretto specification, it corresponds to "Token". challenge-bypass-ristretto has no "Random" flavor of Token. What it does have is randomly generated "Tokens". That is where "RandomToken" got its name (and from the ffi API "token_random"). However, it should just be called "Token".