Giters

LeanerCloud / AutoSpotting

Saves up to 90% of AWS EC2 costs by automating the use of spot instances on existing AutoScaling groups. Installs in minutes using CloudFormation or Terraform. Convenient to deploy at scale using StackSets. Uses tagging to avoid launch configuration changes. Automated spot termination handling. Reliable fallback to on-demand instances.

Home Page:https://autospotting.io

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

ASG on_demand_price_multiplier preference

sdaniel-r7 opened this issue · comments

commented

Github issue

Issue type

  • Bug Report

Build number

build 1.0-custom-f295a1f
Commit SHA1: f295a1f

Configuration

Environment

  • AWS region: us-east-1
  • Type of environment: VPC

Summary

Appears as if the ASG multiplier value is fetched but not utilized. Instead it continues to rely on the lambda multiplier value for price calc.

Steps to reproduce


Create lambda env vars ON_DEMAND_PRICE_MULTIPLIER (0.67) and ASG tags (0.55) for autospotting_on_demand_price_multiplier and launch 2 or more instances

Expected results

When provided, the Auto Scaling Group multiplier should be used

Actual results

When lambda has: ON_DEMAND_PRICE_MULTIPLIER and the Auto Scaling Group also has a multiplier: autospotting_on_demand_price_multiplier, the autospotting code does not use the auto scaling group- instead it relies on the lambda multiplier.

commented

Thanks for reporting this issue.

I currently only work on issues and feature requests submitted by paying customers.

If you installed AutoSpotting from the marketplace tell me your account number on Slack and I'll look into this.

Otherwise I'm going to leave this open just in case someone else is willing to give it a try and contribute a pull request, which I'm more than happy to consider.

commented

@sdaniel-r7 is this still of interest to you?