LeanerCloud / AutoSpotting

Saves up to 90% of AWS EC2 costs by automating the use of spot instances on existing AutoScaling groups. Installs in minutes using CloudFormation or Terraform. Convenient to deploy at scale using StackSets. Uses tagging to avoid launch configuration changes. Automated spot termination handling. Reliable fallback to on-demand instances.

Home Page:https://autospotting.io

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

`make build` forces GOOS=linux

gabegorelick opened this issue · comments

Github issue

Issue type

Bug Report

Build number

master

Summary

The docs mention that make build makes an artifact suitable for running locally, but this is only true if you're on Linux. make build sets GOOS=linux, which is correct if you want to run the executable on Lambda, but not if you want to run it locally on a non-Linux platform.

https://github.com/AutoSpotting/AutoSpotting/blob/9b438dc47cbfd9587b042d5b2aaac2765c28a4e0/Makefile#L46-L48

Steps to reproduce

  1. Run make build on a platform other than Linux.
  2. Run ./AutoSpotting

Expected results

./AutoSpotting runs without errors

Actual results

exec format error: ./AutoSpotting since the executable is not compatible with the current architecture.