LeaVerou / awesomplete

Ultra lightweight, usable, beautiful autocomplete with zero dependencies.

Home Page:http://leaverou.github.io/awesomplete/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

npm version is not 1.1.4

tbslchnr opened this issue · comments

Hi there,
the version 1.1.4 provided by npm is not equal to 1.1.4 of GitHub.
(e.g. aira-expanded functionality is missing)
Any solutions ?

I can confirm as well. Despite having 1.1.4 installed from npm, some accessibility fixes are not present in the code that is shipped. See below a screenshot of the _.ITEM function which is missing role="option" for instance.

Screen Shot 2019-08-16 at 4 36 08 PM

Is there anything we can do to help publish the lastest version to npm please? :)

@hugogiraudel This is really weird. If you want to help, you could investigate what's the latest commit in the npm version, that might give us a hint as to what's going on.

I do see there are 4 commits since 1.1.4, perhaps it's these that are not included? I can make a new release if so.

@LeaVerou hello, thank you for your answer ! That would be great if you could do a new release.
It seems that this issue is about these four commits you mentioned. I think we've been a little confused because the version used in demo and code available in the repo isn't the same that is available on npm.
Both role="option" and aira-expanded were added at the last commit accessibility fixes.

Done! Please lmk if issue is not fixed.