Using !render on some maps causes the entire bot to halt.

Question

Using !render on some maps causes the entire bot to halt.

Kodehawa opened this issue 5 years ago · comments

For example, using !render 20s on https://osu.ppy.sh/b/1529760 makes the entire bot halt for a few minutes.

Maybe other maps could cause the same issue.

Possible fixes could be either excluding Aspire maps or properly implement multithreading on command handling.

Also some of the slider positions of those maps are basically going from inf pos to inf neg. Might want to add an edge case check?

Resuming: Any command that takes too much to answer causes the bot to halt for the duration of the command until it replies. Please implement command multi-threading if possible, or in this case Promise-based commands could work too.

Maaster · Answer 1 · Mon Jul 15 2019 03:58:51 GMT+0800 (China Standard Time)

Just to chime in on this one, I can't reproduce this:

[2019-07-14T19:53:02.387Z] Maaster : !score https://osu.ppy.sh/beatmapsets/537048#osu/1529760 *
[2019-07-14T19:53:02.391Z] returning data for username *
/tmp/osumaps/1529760.osu
[2019-07-14T19:53:03.868Z] getting ur
[2019-07-14T19:53:04.539Z] flowabot :
[2019-07-14T19:53:08.908Z] Maaster : !render 20s
[2019-07-14T19:53:08.910Z] render length 20
[2019-07-14T19:53:08.910Z] specified ar undefined
[2019-07-14T19:53:11.885Z] score has replay
process beatmap: 3497.642ms
[2019-07-14T19:53:12.409Z] downloading beatmap osz
[2019-07-14T19:53:13.486Z] flowabot : Rendering...
[2019-07-14T19:53:13.543Z] downloading from https://osu.gatari.pw/d/537048
[2019-07-14T19:53:15.326Z] resizing image
render beatmap: 10714.129ms
encode video: 8565.589ms
[2019-07-14T19:53:36.090Z] flowabot :

Takes around 30s for me (which is only slightly longer than other maps, in general I need around 15-20s), not multiple minutes.

I agree tho, if it is a problem for others.

Kodehawa · Answer 2 · Mon Jul 15 2019 05:49:34 GMT+0800 (China Standard Time)

tbh, the guy hosting it is doing so in an old laptop. Still quite an issue if it leaves the bot unusable tho

LeaPhant · Answer 3 · Mon Jul 15 2019 06:24:02 GMT+0800 (China Standard Time)

I've just seen this issue and I've implemented circular sliders 2 hours ago in 4e15e1e. Seems like this map works now.

LeaPhant · Answer 4 · Mon Jul 15 2019 14:45:04 GMT+0800 (China Standard Time)

I totally missed the multi-threading part last night. it's already implemented for rendering and encoding but not yet for processing beatmaps which can take long on maps like this I guess.

I'll just appropriate this issue to track the progress of implementing that. :)

LeaPhant · Answer 5 · Mon Jul 15 2019 18:12:18 GMT+0800 (China Standard Time)

Alright, beatmap processing is fully multithreaded as of a16f1ae which also means the "Rendering..." message now appears instantly, even on slow systems!