There is no implementation to get the (Parameter-)ENUMERATION as string only.
astedler opened this issue · comments
I missed the possiboility to get the Enumeration just as a astring (like it is transmitted)
But this could be done easily:
in
libember\Headers\ember\glow\GlowParameterBase.hpp
insert soemwhere around line 347:
/**
* returns the enumration string
* @return Returns the standard enumeration string.
* @author arndt.stedler@dsa-volgmann.de
*/
std::string enumerationString() const
```;
and in
**libember\Headers\ember\glow\impl\GlowParameterBase.ipp** insert somewhere aroun line 312:
LIBEMBER_INLINE
std::string GlowParameterBase::enumerationString() const
{
ber::Value const value = contents().get(GlowTags::ParameterContents::Enumeration());
return util::ValueConverter::valueOf(value, std::string());
}
This looks like a sensible change.
To include it I would like to ask you for explicit permission to implement the change as described, but without any author information in the comment.
If you want author information to be preserved, please create a pull request (also without the author mentioned in the comment) that we can integrate.
Hi Kimon,
Sure thing, permission granted to implement the code and remove the author Information in the comment.
I just added it in my source to find the changes i made.
Mit freundlichen Grüßen / Kind regards
Arndt Stedler
DSA-Volgmann
Inh. Thomas Volgmann
Redcarstr. 20
53842 Troisdorf
Tel: +49 2241 23416 15
Fax: +49 2241 23416 65
email: arndt.stedler@dsa-volgmann.de<mailto:arndt.stedler@dsa-volgmann.de>
web: www.dsa-volgmann.de<http://www.dsa-volgmann.de/>
Von: Kimon Hoffmann<mailto:notifications@github.com>
Gesendet: Mittwoch, 3. Juni 2020 11:13
An: Lawo/ember-plus<mailto:ember-plus@noreply.github.com>
Cc: Arndt Stedler<mailto:arndt.stedler@dsa-volgmann.de>; Author<mailto:author@noreply.github.com>
Betreff: Re: [Lawo/ember-plus] There is no implementation to get the (Parameter-)ENUMERATION as string only. (#108)
This looks like a sensibly change.
To include it I would like to ask you for explicit permission to implement the change as described, but without any author information in the comment.
If you want author information to be preserved, please create a pull request (also without the author mentioned in the comment) that we can integrate.
-
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#108 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AD7NZQ4ELRJ6O6D4NSVYNHDRUYH2RANCNFSM4NROQVQQ>.