Giters

Lawo / ember-plus

Ember+ control protocol - Slick and free for all!

Home Page:https://github.com/Lawo/ember-plus/wiki

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

There is no implementation to get the (Parameter-)ENUMERATION as string only.

astedler opened this issue · comments

commented

I missed the possiboility to get the Enumeration just as a astring (like it is transmitted)

But this could be done easily:
in
libember\Headers\ember\glow\GlowParameterBase.hpp
insert soemwhere around line 347:

            /**
             * returns the enumration string
             * @return Returns the standard enumeration string.
             * @author arndt.stedler@dsa-volgmann.de
             */
            std::string enumerationString() const
```;
and in 
**libember\Headers\ember\glow\impl\GlowParameterBase.ipp** insert somewhere aroun line 312:

LIBEMBER_INLINE
std::string GlowParameterBase::enumerationString() const
{
    ber::Value const value = contents().get(GlowTags::ParameterContents::Enumeration());
    return util::ValueConverter::valueOf(value, std::string());
}
commented

This looks like a sensible change.

To include it I would like to ask you for explicit permission to implement the change as described, but without any author information in the comment.

If you want author information to be preserved, please create a pull request (also without the author mentioned in the comment) that we can integrate.

commented