Giters

Laravel-Lang / lang

List of 126 languages for Laravel Framework, Laravel Jetstream, Laravel Fortify, Laravel Breeze, Laravel Cashier, Laravel Nova, Laravel Spark and Laravel UI.

Home Page:https://laravel-lang.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

The language specific sets of attributes are missing items

madman-81 opened this issue · comments

commented
  • Laravel-Lang Version: 10.3
  • PHP Version: 7.4

Description:

The list of attributes in source\validation-attributes.php and locales\{lang}\validation-attributes.php are not identical. The missing keys aren't in excludes\{lang}.php either.

A few examples (not complete):
DE: missing body, message, photo, price, role, subject and terms but has available, current_password, size extra
NL: missing body, photo, role and terms but has amount, available, teacher, street and others extra

I would at least expect all attributes in source\validation-attributes.php to be present in the language specific file. The extra attributes are understandable and may serve a purpose. However, they make it more difficult to check if all language files are complete. If they aren't used in official supported projects (any more), it might be better to remove them.

Note: also Publisher generates different sets of attributes per language.