Giters

Laravel-Lang / lang

List of 126 languages for Laravel Framework, Laravel Jetstream, Laravel Fortify, Laravel Breeze, Laravel Cashier, Laravel Nova, Laravel Spark and Laravel UI.

Home Page:https://laravel-lang.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

It doesn't possible to add new tags in source/en.json

luisprmat opened this issue · comments

commented
  • Laravel-Lang Version: 9.1.0
  • PHP Version: 8.0.3

Description:

It doesn't possible to add new tags in source/en.json. Tests don't pass and don't allow to do pull request.
Recently i added new translations for the new Password validation rule class and github actions generate errors in test

Steps To Reproduce:

  • Add a commit modifying source/en.json.
  • Push and wait for running Github Actions workflow.
commented

There is error, but I was able to accept the pull request

commented

I can check tomorrow

commented

I remembered why the test was giving an error.

You added new keys to the source/en.json file, but did not add them to all languages.

In this case, we just accept the PR without paying attention to phpunit.

When the PR is accepted, an automatic script is launched that will put down all the necessary keys (php app/keys.php)

Therefore, when adding keys to any file from the source folder, phpunit should be ignored.

It's not bug, it's a feature 😁