Laravel 8
caouecs opened this issue · comments
I updated some informations on this package to include Laravel 8 support.
All is ok for you ?
Yep 😊 Thanks!
I'd like translations to Laravel Jetstream (new autentication scaffolding) . I wish to contribute for spanish
@luisprmat, see this: #1296 (comment)
Reviewing Laravel jetstream in this moment is supporting translations, most of the translatable texts in each of its components are using the notation {{ __(' ') }} ( I have sent some PR about it ). So it is time to think about how we would go about contributing. If a specific package will be created or translations are included in the main --.json of the Laravel Lang. I'd like contribute with spanish (es.json)
@caouecs, to be honest, I would add Jetstream translations to existing json files.
I think this is correct because Laravel Jetstream is a package for the framework and essentially uses its translation files.
Therefore, I think it is wrong to create separate ones.
Reviewing Laravel jetstream in this moment is supporting translations, most of the translatable texts in each of its components are using the notation
{{ __(' ') }}( I have sent some PR about it ). So it is time to think about how we would go about contributing. If a specific package will be created or translations are included in the main--.jsonof the Laravel Lang. I'd like contribute with spanish (es.json)
See #1335
@andrey-helldar to be honest, the question is for the team ;)
it's possible to have a poll in Github issue ?
@caouecs, I'm not sure about the polls, but the discussions can somehow be turned on. For example, https://github.com/laravel/framework/discussions
I just found that : https://github.com/orgs/Laravel-Lang/teams/laravel-lang/discussions
but via the team, not the project
the same thing that I wrote ;)
but it's different than your example with laravel framework, I don't know how to activate it on this project
but it's different than your example with laravel framework, I don't know how to activate it on this project
I found information that discussions now only work for teams. For repositories, they are still being tested (vercel/vercel#3874 (reply in thread))
I can assume that Taylor turned them on at a personal request.
Regardless of the organization that will be given to this project, here is my humble contribution to jetstream translations for the Spanish language. See #1336
I added a discussion to the team: https://github.com/orgs/Laravel-Lang/teams/laravel-lang/discussions/2
Adding to existing is easy and not confusing than Separate files
I think this question can be closed.
Adding to existing is easy and not confusing than Separate files
I agree, it is just a package for Laravel so it should be in same json file, but maybe there will be more lines for the Jetstream and thus a special file will be made just for it, but that will be seen in the future
I think we have solved the Laravel 8 question here, and the new posts are about Laravel Jetstream. I created a discussion on this subject.