problem with lang.json
daltar opened this issue · comments
Hello,
I am currently using the file json/fr.json from your repository.
Everything is translated, except for this line :
"If you’re having trouble clicking the \":actionText\" button, copy and paste the URL below\ninto your web browser: [:displayableActionUrl](:actionURL)": "Si vous avez des problèmes en cliquant sur le bouton \":actionText\", faites un copié/collé de l'url ci-dessous dans votre navigateur :\n [:displayableActionUrl](:actionURL)".
do you have any idea for this?
I am using laravel 6.5.2 btw
You can fork this repository, modify file json/fr.json and send PR.
Or wait for the French-speaking programmer to do this. For example, caouecs 😀
For Laravel 6, you don't need the line with displayableActionUrl ? It's for Laravel 7, is not it ?
For Laravel 6, you don't need the line with displayableActionUrl ? It's for Laravel 7, is not it ?
The line displayableActionUrl affected since Laravel 6.x. Please check here https://github.com/laravel/framework/blob/6.x/src/Illuminate/Notifications/resources/views/email.blade.php#L55
I think it's because laravel don't pass the actionURL only actionText, this is due to a commit 14 days ago
File: email.blade.php
@lang(
"If you’re having trouble clicking the \":actionText\" button, copy and paste the URL below\n".
'into your web browser:',
[
'actionText' => $actionText,
]
) <span class="break-all">[{{ $displayableActionUrl }}]({{ $actionUrl }})</span>
D’ailleurs c'est copier/coller et pas copié/collé
je dirais plutôt copiez et collez
This line:
If you’re having trouble clicking the \":actionText\" button, copy and paste the URL below\ninto your web browser: [:displayableActionUrl](:actionURL)
should be changed to:
If you’re having trouble clicking the \":actionText\" button, copy and paste the URL below\ninto your web browser:
This line:
If you’re having trouble clicking the \":actionText\" button, copy and paste the URL below\ninto your web browser: [:displayableActionUrl](:actionURL)
should be changed to:
If you’re having trouble clicking the \":actionText\" button, copy and paste the URL below\ninto your web browser:
I noticed the same error as you @robertgarrigos in the translation for PL, I corrected the same problem, and only now I noticed that you wrote it here;)
Sorry for the lag
So, I delete ":displayableActionUrl" everywhere ? or I do two lines ( with and without ) ?
just delete [:displayableActionUrl](:actionURL)
done
thx for updating all files :)