Publish a Stable Version for Laravel 5.8
tanmuhittin opened this issue · comments
I am preparing a PR for https://github.com/barryvdh/laravel-translation-manager in order to publish Laravel base lang files when a new locale added. I am planing to use this repository via Laravel-Lang/publisher#3 but https://github.com/barryvdh/laravel-translation-manager requires minimum stability:stable. So I need a stable version of this package for Laravel 5.8
I support!
In my opinion, splitting versions by branch name is not a very good solution.
Alternatively, a major version can be used as a stable branch.
For example:
^3.0 >> Laravel 5.7 and below
^4.0 >> Laravel 5.8+
Connecting the package to projects depends on the version, not on the branches. Versions can be put on different branches.
For example:
master >> 3.0.62, 3.0.63...3.n+1
laravel58 >> 4.0.0, 4.0.1, 4.n+1
This will allow you to make the necessary changes only in the desired branch, as well as use stable versions instead of being developed.
oki dokki
I will do it tomorrow
I am sure that you, @caouecs, can do it without me, but anyway I will post a picture here 😊
(Screenshot from my repository, but the point is clear)
@caouecs, I prepared the necessary changes for both branches ☝ 😊
@caouecs, thank you!
@tanmuhittin, use version ^2.0 version of andrey-helldar/laravel-lang-publisher for a stable Laravel 5.8 and above or ^1.0 for Laravel 5.3-5.7 inclusive.