Giters

Laravel-Lang / lang

List of 126 languages for Laravel Framework, Laravel Jetstream, Laravel Fortify, Laravel Breeze, Laravel Cashier, Laravel Nova, Laravel Spark and Laravel UI.

Home Page:https://laravel-lang.com/packages-lang.html

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Serbian country code issue

arnyee opened this issue · comments

commented

Hello, The Serbian folder nem (sr) is not correct, the correct country code is rs!

commented

Hello,
we respect the iso 639-1 and it's sr

commented

@caouecs

Great package. And right answer on this issue, though for the wrong reasons.

It is true that the ISO 639-1 code for Serbian is sr whereas the ISO 3166 code is rs, which I suspect prompts this issue. However, you also use pt-BR, zc-CN, zh-HK and zh-TW, which aren't ISO 639-1 codes.

I'd suggest the standard that actually matters here is the PHP locale codes. For that the 14 or so flavours of Serbian start "sr" as you have it, so won't break anybody app if they include it.

commented

iso 3166 is for country, not language