[v6] Demo theme-switcher is now broken

Question

[v6] Demo theme-switcher is now broken

tabacitu opened this issue a year ago · comments

Cristian Tăbăcitu commented a year ago

Bug report

What I did:

Went to our online demo - https://demo-v6.backpackforlaravel.com/admin/dashboard
Tried to switch the theme using the top-right button, that opens the modal

What I expected to happen:

Switch the theme

What happened:

Doesn't switch the theme, only switches the layout. The theme stays as tabler, always. Or at least that's what I think.

Cristian Tăbăcitu · Answer 1 · Mon Jun 26 2023 21:16:49 GMT+0800 (China Standard Time)

@jorgetwgroup and @pxpm please have a quick meeting to unblock this 💪

Jorge Castro · Answer 2 · Thu Jun 29 2023 00:19:16 GMT+0800 (China Standard Time)

Hello @tabacitu with this i go deep as i can and discovery why this maybe never work, is because if theme is not loaded in app, switcher will never find views, so i create a provider to register theme in our theme and now is working as expected.

PR: #530

Cheers.