LandSandBoat / server

:sailboat: LandSandBoat - a server emulator for Final Fantasy XI. Just an X-34 landspeeder out for a drive.

Home Page:https://landsandboat.github.io/server/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

πŸ› Automaton counter attack

MowFord opened this issue Β· comments

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my issue will be ignored.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have searched existing issues to see if the issue has already been opened, and I have checked the commit log to see if the issue has been resolved since my server was last updated.

OS / platform the server is running (if known)

Branch affected by issue

base

Steps to reproduce

This commit moved pdif calc to lua, which takes the skill type as a param. I'm curious if there's evidence that automatons use h2h skill explicitly, use a normalized skill for their level, or just simply use automaton_melee as the skill for a counter attack.

Currently, since the change, automatons do 1/4 or less of the dmg compared to their normal autoattacks (due to have zero h2h skill i'm sure)

I don't mind making the PR, just wanted to probe about what suggested route there is

Expected behavior

as monk with no weapon:
image

as sam with hagun:
image

Sorry, missed this issue altogether (work was insane that whole week)

This was an oversight, they should pick the appropriate skill, I'm currently out right now so hopefully I can remember to check this

i am close to a solution, PR incoming