🐛 Server Crash on Casting Maiden's Virelai on Charmed Player
HaxPrime opened this issue · comments
I affirm:
- I understand that if I do not agree to the following points by completing the checkboxes my issue will be ignored.
- I have read and understood the Contributing Guide and the Code of Conduct.
- I have searched existing issues to see if the issue has already been opened, and I have checked the commit log to see if the issue has been resolved since my server was last updated.
OS / platform the server is running (if known)
Windows 11
Branch affected by issue
base
Steps to reproduce
- Get a player character charmed
- Cast "Maiden's Virelai" on the charmed player
Dump provided in a zip.
https://cdn.discordapp.com/attachments/1093630937138466948/1218705509704663113/m_virelai.zip?ex=6608a2f3&is=65f62df3&hm=97544bd5f186d4af238ad107d92dde11dd8a4425425ce35afeb65f1f58013383&
Expected behavior
xi_map should not crash from this.
a yeah, charming an already charmed person basically. oops.
we'll also want the resulting situation in the pathfinding to not be possible. Double bug.
@HaxPrime can you give #5270 a whirl and see if it prevents the crash? without the other pr referenced that prevents casting virelai it'll possibly get some non retail behavior (can't say for sure), but you need to not have that in order to test the crash
Thanks for the quick fixes. Yes running only #5270 prevents the crash. I was able to cast Maiden's Virelai on the charmed player one time. Further attempts gave the "You cannot attack that target." message.
thanks 👍