🐛 H2H offhand accuracy bad
MowFord opened this issue · comments
I affirm:
- I understand that if I do not agree to the following points by completing the checkboxes my issue will be ignored.
- I have read and understood the Contributing Guide and the Code of Conduct.
- I have searched existing issues to see if the issue has already been opened, and I have checked the commit log to see if the issue has been resolved since my server was last updated.
OS / platform the server is running (if known)
Branch affected by issue
base
Steps to reproduce
Log in as a h2h char, attack EP or lower and see massive difference in accuracy between main and offhand
equip a shield and see no difference in main hand accuracy
remove shield and see offhand now has proper accuracy
I believe the change here is causing this code to return 0 skill due to this call and this call
I'm not sure the best way to solve, but i'd guess it would be a change here to make it fall back if slot_sub is null, because currently it just matches nothing if attacknumber == 1