SMN physical Blood Pacts do not check against physical damage type resistances
almuth150 opened this issue · comments
almuth150 commented
I affirm:
- I understand that if I do not agree to the following points by completing the checkboxes my issue will be ignored.
- I have read and understood the Contributing Guide and the Code of Conduct.
- I have searched existing issues to see if the issue has already been opened, and I have checked the commit log to see if the issue has been resolved since my server was last updated.
OS / platform the server is running (if known)
Branch affected by issue
base
Steps to reproduce
Use a physical BP against an elemental and watch it do way too much damage.
Expected behavior
Physical BPs should respect slash/pierce/blunt/h2h modifiers. Elementals have 0.25 for those four across the board. Slashing type BPs should not do damage to Jailer of Fortitude in a form that is immune to slashing damage, etc.
DMGPHYS modifiers do appear to be respected, at least, since I had a phys BP do 0 damage to a mob with Invincible active.