LabSound / LabSound

:microscope: :speaker: graph-based audio engine

Home Page:http://labsound.io

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

biquadfilter's high shelf and low shelf have no effect?

meshula opened this issue · comments

image

(the curve that's showing up is because I captured an image with Brown instead of White noise)

Not a LabSound issue... Here's the canonical WebAudio response curves; selecting the shelf variants, there doesn't seem to be any way to get a curve out of it, at least on Safari:

https://rtoy.github.io/webaudio-hacks/more/biquad/biquad-coef.html

The discussion here - https://github.com/WebAudio/web-audio-api-v2/issues/67 - seems to suggest that the behavior of the shelf modes is unsatisfactory.

So the shelves seem to be broken on WebAudio/WebKit as well. I think we either need proper shelving filters added as a switch inside the BiquadFilter, or we need a new node with a good implementation. Unless if I'm missing something obvious, and there's a parameter to set on the shelves to make it do .... anything at all