Change Docker image to checkout pybind11 specific commit

Question

Change Docker image to checkout pybind11 specific commit

AlexanderTitus opened this issue 7 years ago · comments

Change Docker image to checkout pybind11 specific commit to prevent updates from breaking our build.

Todd Stavish · Answer 1 · Fri Dec 22 2017 02:43:41 GMT+0800 (China Standard Time)

I basically clone the pybind11 head into the container build. I think we can make pybind11 repo a dependency to the pySEAL repo? Or we could clone a tagged version of pybind?

Alexander Titus · Answer 2 · Fri Dec 22 2017 02:50:17 GMT+0800 (China Standard Time)

A tagged version sounds best.

…

-- -- -- -- -- -- -- -- -- -- -- Cheers, *Alexander Titus * <https://www.linkedin.com/in/alexandertitus> Ph.D. Candidate - Program in Quantitative Biomedical Sciences (Data Science) Christensen Molecular Epidemiology Lab <http://www.christensen-lab.com/> School of Graduate and Advanced Studies @ Dartmouth *"*Ad Astra Per Alia Porci <http://www.sjsu.edu/steinbeck/biography/biography_pigasus/>" *-John Steinbeck*

On Thu, Dec 21, 2017 at 10:43 AM, Todd Stavish ***@***.***> wrote: I basically clone the pybind11 head into the container build. I think we can make pybind11 repo a dependency to the pySEAL repo? Or we could clone a tagged version of pybind? — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#3 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AOj44BHwVo5TEc3ocbGvXi2uYedolcvoks5tCqbdgaJpZM4QTUHe> .

kshashwat · Answer 3 · Fri Dec 22 2017 23:44:33 GMT+0800 (China Standard Time)

I've modified Dockerfile to checkout a specific pybind 11 commit (a303c6fc479662fd53eaa8990dbc65b7de9b7deb) after cloning -- I think this should take care of this.

Todd Stavish · Answer 4 · Sat Dec 23 2017 22:42:49 GMT+0800 (China Standard Time)

I think we may still want to add pybind as a repo dependency, instead of a clone. That may avoid the image rebuild each time. It's your call on how inconvenient this is. If your interested Charlie in Cyber could help. Let me know.

…

On Fri, Dec 22, 2017 at 10:44 AM, kshashwat ***@***.***> wrote: I've modified Dockerfile to checkout a specific pybind 11 commit ( a303c6fc479662fd53eaa8990dbc65b7de9b7deb) after cloning -- I think this should take care of this. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#3 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AARCxp1hEuvzfwTv5B00V_cWnIbjqmCqks5tC85hgaJpZM4QTUHe> .

kshashwat · Answer 5 · Sun Dec 24 2017 09:53:13 GMT+0800 (China Standard Time)

Sounds good - by repo dependency do we mean doing something like this: https://github.com/blog/2104-working-with-submodules?

Todd Stavish · Answer 6 · Wed Dec 27 2017 13:04:40 GMT+0800 (China Standard Time)

Yes, that is what I was suggesting. :) Looks like you’ve done most of the porting, so its your call if you think it makes sense to do at this point.

…

On Sat, Dec 23, 2017 at 8:53 PM kshashwat ***@***.***> wrote: Sounds good - by repo dependency do we mean doing something like this: https://github.com/blog/2104-working-with-submodules? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#3 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AARCxtW-A-B5EJXUM-mQGskrIy6dIO2sks5tDa6JgaJpZM4QTUHe> .