LSSTDESC / DC2-analysis

As mentioned here: LSSTDESC/DC2-production#344
This also affects

DC2-analysis/tutorials/dm_butler_lensing_cuts.ipynb

Line 98 in c8f2c16

" calib = butler.get('deepCoadd_calexp_calib', dataId)\n",

Without this change, tests running on this notebook fail with the new version of the desc-stack jupyter kernel using w_2019_19
Michael had mentioned a desire to maintain backward compatibility. Is that necessary? It's not the data, but rather the version of the DMstack used that dictates the template used, so as long as we're all running with >= Run1.2 and using DMstack ~ w_2019_19, this modification would be ok, I think.

Moving to deepCoadd_calexp_photoCalib produces some warnings:

/opt/lsst/software/stack/python/miniconda3-4.5.12/envs/lsst-scipipe-1172c30/lib/python3.7/site-packages/ipykernel/__main__.py:45: FutureWarning: Call to deprecated function (or staticmethod) setThrowOnNegativeFlux. (No-op: PhotoCalib never throws on negative instFlux (will be removed after v18).)
/opt/lsst/software/stack/python/miniconda3-4.5.12/envs/lsst-scipipe-1172c30/lib/python3.7/site-packages/ipykernel/__main__.py:58: FutureWarning: Call to deprecated method getMagnitude. (For backwards compatibility with Calib; use `instFluxToMagnitude` instead (will be removed after v18).)
/opt/lsst/software/stack/python/miniconda3-4.5.12/envs/lsst-scipipe-1172c30/lib/python3.7/site-packages/ipykernel/__main__.py:59: FutureWarning: Call to deprecated method getMagnitude. (For backwards compatibility with Calib; use `instFluxToMagnitude` instead (will be removed after v18).)

Planning to remove:
calib.setThrowOnNegativeFlux(False)

and to modify

data[filter_ + '_mag_CModel'] = calib.getMagnitude(forced['modelfit_CModel_instFlux'])
data[filter_ + '_mag_err_CModel'] = calib.getMagnitude(forced['modelfit_CModel_instFluxErr'])

Fixed by #89

Update from deepCoadd_calexp_calib to deepCoadd_calexp_photoCalib