Should Notebook outputs cleared check be run on push to branch or only on PR?

Question

Should Notebook outputs cleared check be run on push to branch or only on PR?

wmwv opened this issue 4 years ago · comments

Michael Wood-Vasey commented 4 years ago

Should the GitHub Actions check-notebook-outputs script for this DC2-analysis repo be run on every push to a branch or only on a PR?

Michael Wood-Vasey · Answer 1 · Wed Feb 17 2021 23:16:16 GMT+0800 (China Standard Time)

My preference would be only on PR, because I don't want to be discouraged from pushing changes.

But I'm happy to yield to popular opinion.

Michael Wood-Vasey · Answer 2 · Wed Feb 17 2021 23:17:05 GMT+0800 (China Standard Time)

@yymao @JoanneBogart Do you have clear opinions on this?

Yao-Yuan Mao · Answer 3 · Wed Feb 17 2021 23:27:41 GMT+0800 (China Standard Time)

yep, that's fine. I guess it should still run if the commit is pushed to master. We can change the trigger to:

on:
  push:
    branches: [ master ]
  pull_request:
    branches: [ master ]

JoanneBogart · Answer 4 · Thu Feb 18 2021 04:14:57 GMT+0800 (China Standard Time)

Yao's suggestion sounds right to me. Joanne

…

________________________________ From: Yao-Yuan Mao <notifications@github.com> Sent: Wednesday, February 17, 2021 7:28 AM To: LSSTDESC/DC2-analysis <DC2-analysis@noreply.github.com> Cc: Bogart, Joanne R. <jrb@slac.stanford.edu>; Mention <mention@noreply.github.com> Subject: Re: [LSSTDESC/DC2-analysis] Should Notebook outputs cleared check be run on push to branch or only on PR? (#156) yep, that's fine. I guess it should still run if the commit is pushed to master. We can change the trigger to: on: push: branches: [ master ] pull_request: branches: [ master ] — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#156 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABR4RRYHLTKMZWFI25L57B3S7POALANCNFSM4XYQ3YYA>.