Use correct primal values in the sensitivity calls
jamiebramwell opened this issue · comments
Jamie Bramwell commented
As written, the sensitivity calculation calls in the HeatTransfer
and SolidMechanics
modules will not use the correct primal field values (e.g. temperature) during the backward adjoint pass. See
serac/src/serac/physics/heat_transfer.hpp
Lines 921 to 927 in a2d7924
Brandon Talamini commented
We should check that the correct time is used as well. Ideally, we should write tests that fail before patching the bugs.