Giters

LLNL / conduit

Simplified Data Exchange for HPC Simulations

Home Page:https://software.llnl.gov/conduit/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

warning to resolve

cyrush opened this issue · comments

commented 
/ascent/conduit-v0.8.8/src/libs/blueprint/conduit_blueprint_o2mrelation_index.cpp:89:29: warning: implicitly-declared 'conduit::DataAccessor<long int>& conduit::DataAccessor<long int>::operator=(const conduit::DataAccessor<long int>&)' is deprecated [-Wdeprecated-copy]
   89 |         m_offsets_acc = itr.m_offsets_acc;
      |                             ^~~~~~~~~~~~~
In file included from /ascent/conduit-v0.8.8/src/libs/conduit/conduit_node.hpp:35,
                 from /ascent/conduit-v0.8.8/src/libs/conduit/conduit.hpp:25,
                 from /ascent/conduit-v0.8.8/src/libs/blueprint/conduit_blueprint_o2mrelation.hpp:17,
                 from /ascent/conduit-v0.8.8/src/libs/blueprint/conduit_blueprint_o2mrelation_index.cpp:12:
/ascent/conduit-v0.8.8/src/libs/conduit/conduit_data_accessor.hpp:55:9: note: because 'conduit::DataAccessor<long int>' has user-provided 'conduit::DataAccessor<T>::DataAccessor(const conduit::DataAccessor<T>&) [with T = long int]'
   55 |         DataAccessor(const DataAccessor<T> &accessor);
      |         ^~~~~~~~~~~~
commented

This seems to hint we are missing an assignment operator def, but it appears we have a destructor, copy constructor, and assignment operator defined (rule of three)

commented

The assignment operator was added later, not clear about the time relative to 0.8.8 (last release), but this should be resolved.