LGUG2Z / komorebi

A tiling window manager for Windows 🍉

Home Page:https://lgug2z.github.io/komorebi/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[BUG]: Layout breaks if workspace layout is not specified in config

michaelruigrok opened this issue · comments

Describe the bug
According to the config reference, a workspace's layout defaults to the BSP layout. However, if layout is unset, that workspace's layout breaks, causing komorebi to crash.

To Reproduce
Steps to reproduce the behavior:

  1. Set monitors config as the following:
  "monitors": [
    {
      "workspaces": [
        {
          "name": "I",
          "layout": "BSP"
        },
        {
          "name": "II"
        }
      ]
    }
  ]
  1. Swap to workspace II and create a window

  2. Try and toggle floating, move the window, etc

  3. See that the window is not behaving properly

  4. run komorebic stop.

  5. Open up process manager and Note that the komorebi process continues to run.

Expected behavior
The workspace should correctly have the BSP layout applied.

Operating System

OS Name:                   Microsoft Windows 11 Pro
OS Version:                10.0.22631 N/A Build 22631

komorebic check Output

KOMOREBI_CONFIG_HOME detected: C:\Users\ruig01/.config/komorebi

Looking for configuration files in C:\Users\ruig01/.config/komorebi

Found komorebi.json; this file can be passed to the start command with the --config flag

Found C:\Users\ruig01\.config\whkdrc; key bindings will be loaded from here when whkd is started, and you can start it automatically using the --whkd flag

Additional context
N/A

This is actually intended behaviour and the default referred to in the docs applies when a new workspace is created on the fly (is. not defined in the static config file but created using a focus-workspace call).

Passing a None/null value explicitly, or implicitly by omitting the layout key, turns the workspace into a floating workspace.

More info on this:

Configure a Floating Workspace | Tutorial | Komorebi v0.1.19+ | Windows 11 Tiling Window Manager
https://youtu.be/tzSkCYxrhH8

Note to self to update the wording on the docs and add a page on floating workspaces to the mkdocs site